Remove __enter__ and __exit__ from MemorySnapshotProfiler #611
+112
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2023 15:47
Summary: Allows user to configure a `start_step` for when to start recording memory history. Addressing YanjunChen329 's feedback that he would like to record memory history for a specific range of steps, e.g. step 500-503. Also: * improve docstrings * add validation for params * MemorySnapshot callback no longer needs to call `start` and `stop` Differential Revision: D51048945
Summary: There is no need for MemorySnapshotProfiler to be a context manager since it conflicts with start_step and stop_step Differential Revision: D51049497
|
This pull request was exported from Phabricator. Differential Revision: D51049497 |
daniellepintz
pushed a commit
to daniellepintz/tnt
that referenced
this pull request
Nov 7, 2023
Summary: There is no need for MemorySnapshotProfiler to be a context manager since it conflicts with start_step and stop_step Differential Revision: D51049497
daniellepintz
pushed a commit
to daniellepintz/tnt
that referenced
this pull request
Nov 7, 2023
Summary: There is no need for MemorySnapshotProfiler to be a context manager since it conflicts with start_step and stop_step Differential Revision: D51049497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There is no need for MemorySnapshotProfiler to be a context manager since it conflicts with start_step and stop_step
Differential Revision: D51049497